Merge acc6e40aed into bce46bc93f

* Add tests for entity-child relationships and removal in world queries, fixed world_each

* Correct test case

---------

Co-authored-by: Marcus <ukendio@gmail.com>

.github/workflows/analysis.yaml

@@ -16,4 +16,5 @@ jobs:
         
       - name: Analyze
         run: |
-          output=$(luau-analyze src || true) # Suppress errors for now.
+          (luau-analyze src || true) > analyze-log.txt # Suppress errors for now.
+          bash ./scripts/gh-warn-luau-analyze.sh analyze-log.txt

jecs.luau

@@ -1995,6 +1995,7 @@ local function world_each(world: World, id): () -> ()
 			archetype = archetypes[archetype_id]
 			entities = archetype.entities
 			row = #entities
+			entity = entities[row]
 		end
 		row -= 1
 		return entity

scripts/gh-warn-luau-analyze.sh

@@ -0,0 +1,13 @@
+# Read the input file line by line
+while IFS= read -r line; do
+    # Use regex to capture file name, line number, column number, and message
+    if [[ $line =~ ^(.+)\(([0-9]+),([0-9]+)\):\ (.+)$ ]]; then
+        file="${BASH_REMATCH[1]}"
+        line_number="${BASH_REMATCH[2]}"
+        column_number="${BASH_REMATCH[3]}"
+        message="${BASH_REMATCH[4]}"
+
+        # Format output for GitHub Actions
+        echo "::warning file=$file,line=$line_number,col=$column_number::${message}"
+    fi
+done < "$1"

test/tests.luau

@@ -900,20 +900,39 @@ end)
 
 TEST("world:children", function()
 	local world = world_new()
-	local e1 = world:entity()
-	local e2 = world:entity()
-	local e3 = world:entity()
+	local C = world:component()
+	local T = world:entity()
 
+	local e1 = world:entity()
+	world:set(e1, C, true)
+
+	local e2 = world:entity()
+
+	world:add(e2, T)
 	world:add(e2, pair(ChildOf, e1))
+
+	local e3 = world:entity()
 	world:add(e3, pair(ChildOf, e1))
 
-	for entity in world:children(pair(ChildOf, e1)) do
+	local count = 0
+	for entity in world:children(e1) do
+		count += 1
 		if entity == e2 or entity == e3 then
 			CHECK(true)
 			continue
 		end
 		CHECK(false)
 	end
+	CHECK(count == 2)
+
+	world:remove(e2, pair(ChildOf, e1))
+
+	count = 0
+	for entity in world:children(e1) do
+		count += 1
+	end
+
+	CHECK(count == 1)
 end)
 
 TEST("world:clear()", function()
@@ -1562,9 +1581,9 @@ TEST("repro", function()
 		local world = world_new()
 		local component1 = world:component()
 		local tag1 = world:entity()
-		
+
 		local query = world:query(component1):with(tag1):cached()
-		
+
 		local entity = world:entity()
 		world:set(entity, component1, "some data")