From 007097b79170cb0cf94e90c8d2e1fca0e983f26b Mon Sep 17 00:00:00 2001 From: Madison Date: Wed, 10 Dec 2025 12:14:57 -0800 Subject: [PATCH] Correct Cleanup example: Change OnSet to OnAdd (#289) * Correct Cleanup example: Change OnSet to OnAdd `jecs.OnSet` no longer exists. This should be `jecs.OnAdd` instead, which does exist. * Clarify OnAdd hook in cleanup.luau Add comment to clarify OnAdd hook behavior --- examples/hooks/cleanup.luau | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/hooks/cleanup.luau b/examples/hooks/cleanup.luau index 9088ad2..d0c91bd 100755 --- a/examples/hooks/cleanup.luau +++ b/examples/hooks/cleanup.luau @@ -13,8 +13,9 @@ world:set(Model, jecs.OnRemove, function(entity) model:Destroy() end) -world:set(Model, jecs.OnSet, function(entity, model) - -- OnSet is invoked after the data has been assigned. +world:set(Model, jecs.OnAdd, function(entity, id, model) + -- OnAdd is invoked after the data has been assigned. + -- This hook only fires the first time the component is added. -- It also returns the data for faster access. -- There may be some logic to do some side effects on reassignments model:SetAttribute("entityId", entity)